Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compatibility] Added BZMPOP, BZPOPMAX and BZPOPMIN commands #884

Merged
merged 13 commits into from
Jan 22, 2025
Merged

[Compatibility] Added BZMPOP, BZPOPMAX and BZPOPMIN commands #884

merged 13 commits into from
Jan 22, 2025

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the BZMPOP, BZPOPMAX and BZPOPMIN commands to garnet

  • Add BZMPOP, BZPOPMAX and BZPOPMIN commands
  • Add Integration Test cases and ACL Test
  • Add documentation

@Vijay-Nirmal Vijay-Nirmal changed the title Added BZMPOP, BZPOPMAX and BZPOPMIN commands [Compatibility] Added BZMPOP, BZPOPMAX and BZPOPMIN commands Dec 16, 2024
TalZaccai
TalZaccai requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! Thanks for the contribution. Added a few comments.

libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Objects/SortedSet/SortedSetObjectImpl.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/Objects/SortedSetCommands.cs Outdated Show resolved Hide resolved
libs/server/Storage/Session/ObjectStore/SortedSetOps.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespBlockingTests.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemResult.cs Outdated Show resolved Hide resolved
libs/server/Objects/ItemBroker/CollectionItemResult.cs Outdated Show resolved Hide resolved
test/Garnet.test/RespBlockingTests.cs Outdated Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Fixed all review commands

TalZaccai
TalZaccai requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment.

libs/resources/RespCommandsDocs.json Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Please rereview

@TalZaccai
Copy link
Contributor

Please rereview

There's a failing test here, please check...

@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Test failure is because of an issue with COMMAND INFO returning data larger than output buffer because of added commands. I have fixed that issue in my HEXPIRE PR here: 2d918ca#diff-04a556b5467700aa188d8a0b6c06b09221099061cdbcc8997539f76ef9de0207. Since that PR merged, getting latest in this PR solved the test case failure issue

@TalZaccai TalZaccai merged commit 5199485 into microsoft:main Jan 22, 2025
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/BZMPOP-BZPOPMAX-MIN-commands branch January 23, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vijay-Nirmal @TalZaccai